Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v0.17.3 #564

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Version v0.17.3 #564

merged 3 commits into from
Jul 22, 2021

Conversation

RiccardoM
Copy link
Contributor

Description

This PR removes the check of the IBC version inside the x/profiles module, allowing it to connect with any other chain. The check was there due to an old copy/paste and it can be removed safely. Already tested locally with Band Protocol Laozi Testnet 2.

If approved I will tag v0.17.3 from it.

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM
Version 0.17.3
e00e645 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM RiccardoM changed the title Version 0.17.3 Version v0.17.3 Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #564 (8a34178) into master (16e1eeb) will increase coverage by 7.22%.
The diff coverage is 72.83%.

❗ Current head 8a34178 differs from pull request most recent head 010ccbb. Consider uploading reports for the commit 010ccbb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   75.59%   82.81%   +7.22%     
==========================================
  Files          94       91       -3     
  Lines        4519     5470     +951     
==========================================
+ Hits         3416     4530    +1114     
+ Misses        960      737     -223     
- Partials      143      203      +60
Impacted Files Coverage Δ
app/desmos/cmd/root.go 0.00% <0.00%> (ø)
x/commons/commons.go 100.00% <ø> (ø)
x/profiles/keeper/msg_server_app_link.go 0.00% <0.00%> (ø)
x/profiles/keeper/relay_app_links.go 95.38% <ø> (ø)
x/profiles/keeper/relay_chain_links.go 87.09% <ø> (+0.43%) ⬆️
x/profiles/simulation/decoder.go 63.15% <ø> (-28.85%) ⬇️
x/profiles/types/account.go 57.04% <ø> (+5.63%) ⬆️
x/profiles/types/codec.go 100.00% <ø> (ø)
x/profiles/types/genesis.go 95.74% <ø> (+9.53%) ⬆️
x/profiles/types/models_app_links.go 92.38% <ø> (ø)
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d083470...010ccbb. Read the comment docs.

@RiccardoM RiccardoM force-pushed the version/v0.17.3 branch 3 times, most recently from 8a34178 to e00e645 Compare July 21, 2021 11:04
@RiccardoM RiccardoM requested review from leobragaz and dadamu July 21, 2021 11:05
leobragaz
leobragaz approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dadamu
dadamu approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

RiccardoM
RiccardoM commented Jul 21, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@RiccardoM RiccardoM merged commit ebbbfd5 into master Jul 22, 2021
@RiccardoM RiccardoM deleted the version/v0.17.3 branch July 22, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobragaz leobragaz leobragaz approved these changes

@dadamu dadamu dadamu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RiccardoM @dadamu @leobragaz